StandUpStreak - implement internal counter #345
Conversation
|
Actually @LucyAnne98 we still need that database migration commited |
There was a problem hiding this comment.
Aside my comments...
...please rename the variable Regex on the line 52 in the file src/HonzaBotner.Discord.Services/Jobs/StandUpJobProvider.cs to something else. It's shadowing the Regex type imported by using System.Text.RegularExpressions;, it's ugly and it makes everyone cry.
Co-authored-by: Ondřej Štorc <[email protected]>
Co-authored-by: Ondřej Štorc <[email protected]>
|
Oh, I see you changed the functionality in #344. I have removed the last streak's completed and total counters in the DB. Will add that back in the evening... |
|
@LucyAnne98 can you just quickly check if it follows your idea on how it should have worked? I just hope it's what you wanted and that we haven't tampered with your idea too much... But feel free to request any more changes, or do them yourselves. Thanks a lot for help and initial implementation. |
|
|
||
| if (OkList.Any(s => state.Contains(s))) | ||
| foreach (Match match in TaskRegex.Matches(msg.Content)) |
There was a problem hiding this comment.
| foreach (Match match in TaskRegex.Matches(msg.Content)) | |
| foreach (var match in TaskRegex.Matches(msg.Content)) |
to keep it consistent with previous loop.
There was a problem hiding this comment.
This actually turned everything red, so I kept it the way it is now.. For some reason once we substitute Mtch for var, it no longer knows that var contains some groups...
Implements:
per member DM with last day results & best streak